Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pnp): suppress experimental ESM loader warning #4338

Merged
merged 1 commit into from
Apr 9, 2022
Merged

fix(pnp): suppress experimental ESM loader warning #4338

merged 1 commit into from
Apr 9, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 9, 2022 •
edited
Loading

What's the problem this PR addresses?

Node.js v17.9.0 changes the experimental ESM loader warning so it isn't suppressed anymore.

Ref nodejs/node#42314
Ref https://github.com/nodejs/node/releases/tag/v17.9.0

How did you fix it?

Updated the code to suppress the warning.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz added the esm label Apr 9, 2022
@arcanis arcanis merged commit 14757f0 into master Apr 9, 2022
@arcanis arcanis deleted the merceyz/fix/esm-loader-warning branch April 9, 2022 20:52
@kachkaev kachkaev mentioned this pull request Apr 24, 2022
Closed
merceyz added a commit that referenced this pull request May 12, 2022
@merceyz
fix(pnp): suppress experimental ESM loader warning (#4338)
14491df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis